search

LartTyler / MHWDB-API

Source code for the Monster Hunter World API project
GNU Affero General Public License v3.0
74 stars 11 forks source link

[SUGGESTION] Add Unique Identifiers to Charm Ranks #165

Open DeveloperPaul123 opened 4 years ago

DeveloperPaul123 commented 4 years ago

Currently in the API, skill ranks have unique identifiers provided by the API. Is there any reason for charm ranks to have also have unique identifiers?

LartTyler commented 4 years ago

They do actually have IDs internally, they just aren't exposed in the result sets. That's a holdover from when the data was scraped from Kiranico and the ranks set had to be rebuilt with each scrape, meaning the IDs weren't stable between scrapes. Since we've moved away from that and the IDs are (relatively) stable now, that's definitely something I can add back in.

DeveloperPaul123 commented 4 years ago

This would be extremely helpful for me if it's possible to add the ids back in. 👍