search

LartTyler / MHWDB-Docs

API documentation for the Monster Hunter World API (https://mhw-db.com)
Other
62 stars 6 forks source link

Add Skill Name to Skill property #14

Closed HumbertoMendes closed 6 years ago

HumbertoMendes commented 6 years ago

Could you please add the Skill Name when returning the Skill property? I can parse it using the slug, but it would be awesome if the name returned along with the other properties.

LartTyler commented 6 years ago

Hmm.. So here's the thing. If I add something like skillName to ranks, that column doesn't exist on the skill ranks table in the DB, so it wouldn't be query-able. Which isn't necessarily an issue, but it just means that I need to start marking fields as query-able or not, and it makes things a bit less intuitive for a developer in the future.

Not that this is a great solution, but would it be too much to just query the skill endpoint to get the name? All of the endpoints have very strong caching, so it should resolve pretty quickly.

baaronp7 commented 6 years ago

Tyler,

Could you just have a "displayName" in the skill property? Having to query again to get the name is a hassel expecially when dealing with such a large data set when interacting over each piece of armor. Having to call the skill endpoint for each instance of a skill in a armor piece adds exponential amount of calls.

Thanks, Aaron

On Sun, Apr 15, 2018, 6:39 PM Tyler Lartonoix notifications@github.com wrote:

Hmm.. So here's the thing. If I add something like skillName to ranks, that column doesn't exist on the skill ranks table in the DB, so it wouldn't be query-able. Which isn't necessarily an issue, but it just means that I need to start marking fields as query-able or not, and it makes things a bit less intuitive for a developer in the future.

Not that this is a great solution, but would it be too much to just query the skill endpoint to get the name? All of the endpoints have very strong caching, so it should resolve pretty quickly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LartTyler/MHWDB-Docs/issues/14#issuecomment-381456793, or mute the thread https://github.com/notifications/unsubscribe-auth/AJvWkBtUl5zsqyKj-F3wYyxaVJl5Ocndks5to_ZdgaJpZM4TVSgH .

LartTyler commented 6 years ago

Yep, that was the counterargument I was expecting. I'll add it to my backlog.

baaronp7 commented 6 years ago

Thanks

On Sun, Apr 15, 2018, 7:48 PM Tyler Lartonoix notifications@github.com wrote:

Yep, that was the counterargument I was expecting. I'll add it to my backlog.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LartTyler/MHWDB-Docs/issues/14#issuecomment-381465342, or mute the thread https://github.com/notifications/unsubscribe-auth/AJvWkDGDDxs68J7yhuGi89Ad-i4td_63ks5tpAaLgaJpZM4TVSgH .

LartTyler commented 6 years ago

The skillName field is now available on skill ranks in v1.6.3.

HumbertoMendes commented 6 years ago

Thank you Tyler.