Revamp popup.html settings page

[nhfruchter]

Hi there! Thanks for making the plugin, I've found it really helpful. I wanted to clean up and add some structure (both HTML/CSS-wise and visually) to the settings page, both for usability as well as future extensibility. Feel free to incorporate none (or all) of it :)

A summary of changes:

• Broke settings page into <section>s, removed all inline styles, and pulled styles into a new .css
• Themed the settings page using Mastodon colors, set padding and font sizes based on relative units
  • Moved the "settings saved" message into the save button itself
• Rewrote setting names, headers, and copy to reduce the need to reference the README.
  • For example, Run if logged in -> Also enable on instances where I'm logged in, Whitelist -> Only run on these servers, Submit -> Save

Changes to the names of settings were done in an opinionated manner, so feel free to re-write if you'd like.

The new UI:

[Lartsch]

Hi there!

I really appreciate your efforts (it looks really good), but there's an unlucky coincidence: I talked with @Freeplayg last night about revamping the design, and just about an hour before your pull request, he submitted his one (#21).

Since I already talked to @Freeplayg, I'll prefer his pull request. But I will make sure to cherry-pick your changes and add them to what was done in #21. For example, you have also changed the wording, which will close #22.

So you can be sure I'll consider all the changes you made, but I can't accept the lull request as a whole

Sorry about that.

[nhfruchter]

No problem! Dark mode was next on my list after this, so I'm glad someone got around to it.

On Mon, Dec 19, 2022 at 11:31 PM Lartsch @.***> wrote:

Hi there!

I really appreciate your efforts (it looks really good), but there's an unlucky coincidence: I talked with @Freeplayg https://github.com/Freeplayg last night about revamping the design, and just about an hour before your pull request, he submitted his one (#21 https://github.com/Lartsch/FediAct/pull/21).

Since I already talked to @Freeplayg https://github.com/Freeplayg, I'll prefer his pull request. But I will make sure to cherry-pick your changes and add them to what was done in #21 https://github.com/Lartsch/FediAct/pull/21.

For example, you have also changed the wording, which will close #22 https://github.com/Lartsch/FediAct/issues/22.

Sorry about that.

— Reply to this email directly, view it on GitHub https://github.com/Lartsch/FediAct/pull/23#issuecomment-1358946032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXZYXFEMCROGYI6DAM6WLWOFODTANCNFSM6AAAAAATEFQIC4 . You are receiving this because you authored the thread.Message ID: @.***>

[nhfruchter]

I'm sure I'll be able to take a look at something else on the issues list at some point :) Thanks again!