search

Lartu / ldpl

COBOL-like programming language that compiles to C++. With serious dinosaurs with neckties and briefcases 🦕💼
https://www.ldpl-lang.org/
Apache License 2.0
160 stars 24 forks source link

Update to fix install error #198

Closed JohnBlood closed 1 year ago

JohnBlood commented 2 years ago

This change fixes an error where the language file fails to install for Gedit 4 on Fedora 35. This reflects Gedit's move from GTK3 to GTK4.

JohnBlood commented 2 years ago

Quick note: I'm not sure if Gedit 4 is available on distros other than Fedora. (The about page says that it is version 4.1 Alpha.) Also, as far as I can tell, Pluma has not been updated to GTK4. It might be a good idea to wait until Gedit 4 is released.

Oppen commented 2 years ago

Wouldn't this patch break install for users of the older version?

JohnBlood commented 2 years ago

Wouldn't this patch break install for users of the older version?

I think it might. Maybe it would be a better Idea to have the script check to see what version of Gedit is installed and continue the installation based on that. That's beyond my skill.

Oppen commented 2 years ago

Is the script run manually? If so, maybe just copy paste and have two of them. It's a one liner, so it should be a problem.

Lartu commented 2 years ago

Hi there! Yes, maybe having two of them would be the easiest solution, as they are ran manually. I'd create a gedit4 folder with the file inside and call it a day!

Lartu commented 1 year ago

Hi there, maybe we could move this to its own repository? 🤔 Please see https://github.com/Lartu/ldpl/issues/207.

Lartu commented 1 year ago

Sorry for closing this issue! I'd rather have a separate repository for highlighting files. This repo has become too big in the past and we are trying to avoid that. It gets too confusing. Sorry! :(