LasCC / HackTools

The all-in-one browser extension for offensive security professionals 🛠
https://hacktools.sh
5.81k stars 646 forks source link

Semantic versioning for releases #50

Closed someshkar closed 4 years ago

someshkar commented 4 years ago

At the moment, loading Hack-Tools in my Chromium based browser throws an error with the version number defined in the manifest.json file, specifically because the version is 0.1.2b. This is what the file looks like at the moment (as of this release):

{
  "name": "Hack Tools",
  "version": "0.1.2b",
  "description": "The all in one Red team extension for web pentester",
  "browser_action": {
    "default_title": "Hack Tools",
    "default_popup": "index.html",
    "default_icon": {
      "16": "get_started16.png",
      "32": "get_started32.png",
      "48": "get_started48.png",
      "128": "get_started128.png"
    }
  },
  "icons": {
    "16": "get_started16.png",
    "32": "get_started32.png",
    "48": "get_started48.png",
    "128": "get_started128.png"
  },
  "manifest_version": 2,
  "devtools_page": "devtools.html"
}

Switching 0.1.2b to 0.1.2 manually seemed to fix the issue for me, and it'd be great if this change could be incorporated in the next release too.

rb-x commented 4 years ago

Thank you @someshkarfor for reporting the manifest issue, I added the 0.1.2b to make the extension valid for the mozilla plugin store, but I didn't know it caused an error for the chromium browser.

someshkar commented 4 years ago

@rb-x Sounds great, thanks!