search

LaserWeb / LaserWeb4-Binaries

Installers for LaserWeb4
GNU Affero General Public License v3.0
307 stars 57 forks source link

Abandoned project ? #37

Open FrankHovis opened 3 years ago

FrankHovis commented 3 years ago

Its over 2 years now since any activity here, has this been abandoned?

dgoadby commented 3 years ago

It seems so. I use this so did wonder if Frank would agree to it being forked or transferred to someone who is active in the group. There are a few bugs to clear up and some improvement test I would want.

cprezzi commented 2 years ago

The frontend devs have left the project, but I could give new devs acces to this repo, if someone is capable of taking over. The frontend is based on react and redux.

webii commented 2 years ago

I am a fullstack dev and using this software a lot. As I am using raspberry pi zero w, LaserWeb is a perfect solution for remote working. But there are a few bugs which are really painful. I would like to fix them if I can get at least some support and code review.

cprezzi commented 2 years ago

I am open for pull requests and will support you as good as I can. Just tell me what you need to know.

webii commented 2 years ago

Is there any way to contact you more directly, like using private messages or discord? First I started looking on server code. But before any serious changes I needed to do some clean up, to remove duplicated code :/ https://github.com/webii/lw.comm-server/pull/1

cprezzi commented 2 years ago

I am still maintaining the server code. What we realy need are frontend devs.

I saw your refactoring, which chages a lot of code according to your personal preferences. Are you willing to take over backend maintenance for the the next few years?

You also removed the App folder, which is the hosted frontend. This is needed for server only installations (like RPi) which are used by browser over network. Did you consider all usecases (server only, server & app, app only)?

webii commented 2 years ago
  1. There is no change in logic in my MR.
  2. Changes are not due to my preference, but due to the good practices, as code there were duplicated three times, and still in many places is. Because for each type of connection there was the same (almost) code. It is hardly manageable.
  3. Fronted app is not needed there. It could be installed by downloading from the other repository. I will add a message in the readme for those who need hosting also frontend. As someone is working on raspberry pi this frontend is not needed as you can connect from any frontend (electron) providing raspberry pi address and port. Also providing frontend on the server side might also be misleading, because there is no way to use laser cutter for more than one person/session, also the web session cannot be shared.
  4. I have removed linux binary. Those binaries could be added as artifacts when building specific release, they don't have to be part of a code repository.
cprezzi commented 2 years ago
  1. I agree.
  2. I partly agree but using let instead of var (ts over vanilla) is just personal preference.
  3. Many users have a pi as the server and don't want to install an app for the frontend but instead just use a webbrowser on a PC or tablet. The hosted app is also needed in the case when the electron exe is run as server and the frontend wants to be used by webbrowser. By the way: It IS possible to connect multiple frontends to the same server. Each frontend will show the actual position and can pause, resume, stop the job or change feed and spindle. Even the whole gcode is sent to second frontend, it just cant show the job jet.
  4. I agree.
helifino commented 2 years ago

However, now there's no linux build in Releases. For someone trying to install to Linux desktop, but not comfortable building from sources, this is unusable.

cprezzi commented 2 years ago

@helifino The installation process for Linux is described on https://github.com/LaserWeb/lw.comm-server/wiki/Manual-Installation-(RasPi)

helifino commented 2 years ago

Please then update the Installation (Linux) page. https://laserweb.yurl.ch/documentation/installation/34-install-linux-appimage-format

cprezzi commented 2 years ago

Thanks for that hint! I completely forgot this page.

helifino commented 2 years ago

The installation process for Linux is described on https://github.com/LaserWeb/lw.comm-server/wiki/Manual-Installation-(RasPi)

This fails the no-coding-knowledge test. Had to determine and solve several dependency issues just to install, and still it does nothing. Connect via browser gives 'connecting to server' in the status pane but no connection. Linux Mint 20.3

cprezzi commented 2 years ago

@helifino Did you get the frontend in the browser? Did you set the correct server connection? (Go to the comms tab, click "Server Connection" edit "Server IP" to own IP:8000 and hit connect) What was shown in the console where you started the server.js?

helifino commented 2 years ago

Oddly, without changing anything, now it's actually connecting to itself but not to the laser: image

cprezzi commented 2 years ago

It seems like server.js does not have the right to open /dev/ttyUSB0. Are you sure that this is the correct interface? On Raspberry Pi, it is /dev/ttyAMA0. You could also try if it works when you start the server app with superuser rights (sudo).

helifino commented 2 years ago

Yes, this is not a pi.

helifino commented 2 years ago

Point of clarification: Desktop version can communicate with machine. Comms server cannot. Launched from same user account.

cprezzi commented 2 years ago

Unfortunately I am not a Linux guy, so I can't realy help. I just remember that another user pointed out that Linux is very restrictive with access to ressources and the right to acces ttyUSB0 needs to be explicitly configured.

I know that you are not using a pi, I just mentioned that on a pi it would be ttyAMA0. I don't know what is correct on your Linux.