LaserWeb / LaserWeb4

Collaborative effort on the next version of LaserWeb / CNCWeb
GNU Affero General Public License v3.0
702 stars 190 forks source link

Feed unit selection not being honored in Jog>Control #200

Closed cojarbi closed 7 years ago

cojarbi commented 7 years ago

Reported by Walter K on G+

When choosing mm/min in Settings> Application, Should Jog>Control be changed to mm/min also?

Im not sure if we discussed this in the past and decided not to change that, but it makes sense

capture

ghost commented 7 years ago

To elaborate, it doesnt follow what you selected in Settings tab?

cojarbi commented 7 years ago

Correct, so if i choose mm/min in settings, jog>control keeps displaying mm/s ( Am i that bad at describing :) )

cprezzi commented 7 years ago

You are right, it should change corresponding to the units set. I probably just forgot it. ;) I will check that.

cprezzi commented 7 years ago

Corrected with commit https://github.com/LaserWeb/LaserWeb4/commit/5bbbf72cc8440abdce1c8df1c68107e7f0425bc5

cojarbi commented 7 years ago

@cprezzi not sure if you also want to change this so its consistent

screen shot 2017-03-12 at 3 50 13 pm
ghost commented 7 years ago

Can anyone explain why the G0 Feedrate is needed here and how its used? Does it override the default value? Is it used in GCode generation?

cprezzi commented 7 years ago

@cojarbi Where is that field from?

ghost commented 7 years ago

@cprezzi I think it's the one under the simulator slider

cojarbi commented 7 years ago

Sorry main screen, bellow the canvas

cprezzi commented 7 years ago

Ah ok. I did not program that. Think thats for the CAM.

ghost commented 7 years ago

@tbfleming Can you shed any light on the reason and function of this slider?

tbfleming commented 7 years ago

Everything in this area affects the workspace, and nothing else:

image

The G0 Feedrate field is for time estimation that the Simulator slider uses.

ghost commented 7 years ago

@tbfleming Where is this estimation found?

This naming is ambiguous and easily confused by users as to what it relates to. I can see it useful if you could playback the simulator, but i don't this this is possible? Either way, a more appropriate name should be used.

tbfleming commented 7 years ago

The slider position is proportional to simulation time. Far left is time 0 and far right is estimated end time.

The naming is exactly what it says: G0 Feedrate tells the simulator what feed rate G0 is. The simulator doesn't know since it doesn't talk to the firmware.

You can playback the simulator; just move the slider. After you click on it you can also hold down the left or right arrow keys.

ghost commented 7 years ago

By calling it G0 Feedrate causes it to be confused with actual G0 feed-rates. As I said, it is ambiguous.

Can I suggest calling it something more appropriate to the simulator? 'Simulator Speed" "Simulator Estimation Speed" "Simulation G0"

tbfleming commented 7 years ago

It's now "Sim G0 Feed".

ghost commented 7 years ago

Thx Todd.