LaserWeb / deprecated-LaserWeb1

Deprecated: use http://github.com/openhardwarecoza/LaserWeb3 instead
186 stars 45 forks source link

Experimental adaptive feedrate on raster while unchecked #100

Closed cojarbi closed 8 years ago

cojarbi commented 8 years ago

Raster is generating speed variation even though the setting has not been chosen. Its doing an average between the G1 and G0 setting. Should it to this?

screen shot 2016-02-03 at 10 30 18 pm

GCODE-LaserWeb (1).gcode.txt

ghost commented 8 years ago

@nathanielstenzel are you handling the unticking too? I think i saw this too, but after generating a job with adaptive ticked, then opening a second file and unticking. @cojarbi or is it on first open for you?

cojarbi commented 8 years ago

First open. Freshly started server and loaded page.

nathanielstenzel commented 8 years ago

I am positive this was working. The checked/unchecked status is not getting through. The last time I tried adjusting anything, I could not get a check box status to get through to laserraster.js. I did the same thing that the other checkbox was doing. It did not work. I searched online and tried something else and still no luck. I thought I was either going crazy or needed sleep. This was a week or two ago. I am surprised that nobody would have complained during that time period. As for me, I have not committed any code else than the one that was rolled back via someone's pull/merge and then the re-inserting of it directly into your code. That was the end-line optimization code. The button I tried to add in was a toggle for end-line optimization.

nathanielstenzel commented 8 years ago

this.config.useVariableSpeed should be true or false in laserraster.js.

cojarbi commented 8 years ago

@nathanielstenzel can you fix this please, please, please? It slowing me down. I cannot get a full power or constant speed on raster.

ghost commented 8 years ago

I can reproduce the issue...

ghost commented 8 years ago

Found the bug...

http://heyjavascript.com/javascript-string-to-boolean/ told me how to fix it (;