search

LaserWeb / deprecated-LaserWeb3

Open Source Laser Cutter / Engraver software. Supports gcode, svg, dxf, stl, png, jpg, bmp
266 stars 68 forks source link

object to default parameters when importing new object #114

Closed fumblz-n-action closed 8 years ago

fumblz-n-action commented 8 years ago

I imported an image and sized it accordingly and gave it an off set. next i imported another object (dxf file) then image file reverted back to its defaulted original imported size and placement,

krolco commented 8 years ago

I am able to reproduce this. Someone (maybe me?) will have a look.

krolco commented 8 years ago

OK, I've been looking at the code, and I think is a side-effect of an earlier feature that I did ( #104). I have to think about how to fix this a bit more. I'll try to look at it again tonight.

krolco commented 8 years ago

Ok, I just merged #120 that should finally fix this -- I didn't quite get it right the first time, but I spent more time grokking the code, and it should work now. I was accidentally resetting the raster's position anytime another object was added to the scene (because I didn't understand that I added the code in a spot that made a pass over all objects every time something was added to the scene, instead of once at first add). @fumblz-n-action, please test this now if you can.

cojarbi commented 8 years ago

I can confirm

krolco commented 8 years ago

Does this seem OK now? I'd like to close it if possible. @cojarbi @fumblz-n-action Thank you!

cojarbi commented 8 years ago

I did check it and passed fine

AY

On Sep 9, 2016, 13:21, at 13:21, Monte Krol notifications@github.com wrote:

Does this seem OK now? I'd like to close it if possible. @cojarbi @fumblz-n-action Thank you!

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openhardwarecoza/LaserWeb3/issues/114#issuecomment-245996604

krolco commented 8 years ago

Thank you. I'm going to close this one then.