search

LaserWeb / deprecated-LaserWeb3

Open Source Laser Cutter / Engraver software. Supports gcode, svg, dxf, stl, png, jpg, bmp
265 stars 68 forks source link

[Question] Why do the settings need to be reloaded after saving? #160

Closed jorgerobles closed 7 years ago

jorgerobles commented 7 years ago

Taking a brief look to the code cannot find the reason the interface alerts to reload page for settings to take effect. localStorage should be updated immediatly. Is there any application feature that prevents this?

ghost commented 7 years ago

The threejs grid size, for example, needs a refresh

On Oct 18, 2016 11:42 AM, "jorgerobles" notifications@github.com wrote:

Taking a brief look to the code cannot find the reason the interface alerts to reload page for settings to take effect. localStorage should be updated immediatly. Is there any application feature that prevents this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/160, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr23GVOYkE_qaw1LbmoLvellAG6Styks5q1JSCgaJpZM4KZlGy .

ghost commented 7 years ago

Which @tbfleming is addressing already with React https://plus.google.com/101442607030198502072/posts/VzfbPqr26Ye in LW4

ghost commented 7 years ago

(Closing this one since thats basically resolved in LW4)