LaserWeb / deprecated-LaserWeb3

Open Source Laser Cutter / Engraver software. Supports gcode, svg, dxf, stl, png, jpg, bmp
265 stars 68 forks source link

[Enhancement] Refactor threegcode on to a library #161

Closed jorgerobles closed 7 years ago

jorgerobles commented 7 years ago

Issue #160 comes for a forth study of refactoring the threegcode on to a library, allowing to use gcode generator alone, decoupling from interface dependencies (like laserMultiply fetching from UI field) and doing "dependecy injection" of application settings and maybe document (SVG, DXF) scoped settings. This will allow to improve #52 development.

ghost commented 7 years ago

Agreed. Also @tbfleming is helping us add his cam code from jscut.org, so definitely the cam portion needs a lot of work. Again, this needs to happen in the step of porting lw3 sections to lw4. Speak to @lautr3k and see if he can give some guidance on how best to start porting code over to lw4?

On Oct 18, 2016 11:51 AM, "jorgerobles" notifications@github.com wrote:

Issue #160 https://github.com/openhardwarecoza/LaserWeb3/issues/160 comes for a forth study of refactoring the threegcode on to a library, allowing to use gcode generator alone, decoupling from interface dependencies (like laserMultiply fetching from UI field) and doing "dependecy injection" of application settings and maybe document (SVG, DXF) scoped settings. This will allow to improve #52 https://github.com/openhardwarecoza/LaserWeb3/issues/52 development.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/161, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr22AvLro6_vqiw2SrPhnXNcN4xacrks5q1JaMgaJpZM4KZlqh .

jorgerobles commented 7 years ago

Perfect!

ghost commented 7 years ago

Can I close this issue, and we continue looking at it in the react/redux based LW4?

jorgerobles commented 7 years ago

Of course!