LaserWeb / deprecated-LaserWeb3

Open Source Laser Cutter / Engraver software. Supports gcode, svg, dxf, stl, png, jpg, bmp
265 stars 68 forks source link

Started an optimisation repo #178

Closed ghost closed 6 years ago

ghost commented 7 years ago

I wanted to integrate lw.rasterizer but I can not for now... And to be honest I am also lost on the v4 ... So I begin to modularize and optimize the V3. My attempt is to scope all "module", starting with simple things like menu and localStorage.

https://github.com/LaserWeb/LaserWeb3/tree/optimization

jorgerobles commented 7 years ago

I'm currently testing your rasterizer and is amazing. Superb job!

ghost commented 7 years ago

Thanks @jorgerobles

cprezzi commented 7 years ago

@lautr3k : You are right, there is a lot of optimization potential in LW3. I was also thinking about some optimizations, especially better separation of frontend and backend. I'd like to push all communication with controller boards to the backend, so the frontend only communicates with the backend and nothing else.

I hope we could combine our work later on.

ghost commented 7 years ago

I think its a good idea. Stepping stone between where we are and we are headed. Would make the final porting of modules to react easier. One change at a time @tbfleming

On Nov 10, 2016 4:27 PM, "Claudio Prezzi" notifications@github.com wrote:

@lautr3k https://github.com/lautr3k : You are right, there is a lot of optimization potential in LW3. I was also thinking about some optimizations, especially better separation of frontend and backend. I'd like to push all communication with controller boards to the backend, so the frontend only communicates with the backend and nothing else.

I hope we could combine our work later on.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb3/issues/178#issuecomment-259703077, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr25QFoVzF7IbC7DlgTiNKefh0ATDAks5q8ymzgaJpZM4KurjM .

tbfleming commented 7 years ago

Testing note: turn on the Perspective checkbox below the Workspace to be able to drag documents around the screen. I need to fix that for the orthoganal camera.

ghost commented 7 years ago

@tbfleming maybe the wrong topic ?

ghost commented 7 years ago

I think that was notes to you on whats needed to integrate the lw.rasterizer into lw4: ie add raster engrave as an operation

On Nov 10, 2016 6:04 PM, "Sébastien Mischler (aka skarab)" < notifications@github.com> wrote:

@tbfleming https://github.com/tbfleming maybe the wrong topic ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaserWeb/LaserWeb3/issues/178#issuecomment-259729825, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr2xouLlpXd97MtH9alaySD2sWQi6mks5q80CLgaJpZM4KurjM .

ghost commented 7 years ago

@nraynaud - https://github.com/LaserWeb/LaserWeb3/issues/178#issuecomment-259724085 would thus be instructions if you would like to help out porting your Dragknife code (and other useful operations) into https://github.com/LaserWeb/LaserWeb4

ghost commented 7 years ago

Splited index template in smaller parts b80f77dc76cd4382d411707860b8f66123c89db5. See how the index file look right now https://github.com/LaserWeb/LaserWeb3/blob/optimization/public/index.html#L31

nraynaud commented 7 years ago

@openhardwarecoza I am on a contract at the moment, but I am still thinking about helping.

ghost commented 7 years ago

All cool! Just posting notes as I think about you - might be helpful later when you need to refer back (:

tbfleming commented 7 years ago

I think that was notes to you on whats needed to integrate the lw.rasterizer into lw4: ie add raster engrave as an operation

Yes. I assumed that's why you pinged me.

tbfleming commented 7 years ago

It looks like we may have a clash with the term 'engrave'. In jscut, it means follow an outline without offset (engrave vs. inside vs. outside). If we use 'engrave' to mean 'raster', then we need a different term for following outlines.

ghost commented 7 years ago

So far its always been called "raster" in lw1-3

cprezzi commented 7 years ago

follow a line could call on-line ;)

ghost commented 7 years ago

Although this thread is lacking some updates the descriptions in https://github.com/LaserWeb/LaserWeb3/commits/optimization is amazing. Go check it out and ask @lautr3k where he needs help

ghost commented 7 years ago

@lautr3k - just checking in for a status update As the cam portion of LW4 made big strides since the start of this, i need to start thinking at which point we cross over from working extensively on lw3 to focussing on lw4 All lw4 is missing is comms and raster really

ghost commented 7 years ago

Saddest issue to close - but looks like all that work for nothing... As we have LW4 ready to go. Thanks again @lautr3k - that definately helped along a lot of the other steps!

ghost commented 7 years ago

Reopening the issue (:

An opportunity arose to reuse this branch! Yay! All that code WAS NOT FOR NOTHING after all!