Add default jog speed in config

[cojarbi]

Can we have default jog speed in config also?

[ghost]

Instead of default in settings - I think "keeping last used value" may make more sense?

[cojarbi]

I like that.  Is just a repetitive task that I don't think you need to move very often

AY

On Aug 17, 2016, 06:15, at 06:15, Peter van der Walt notifications@github.com wrote:

Instead of default in settings - I think "keeping last used value" may make more sense?

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-240382530

[ghost]

A step further we could think of a profile system ?

[ghost]

Eventually yes.. Pronterface currently uses the "last used" way and its quite nice

[krolco]

This seems like it's in my wheelhouse. I'll try to swing at this weekend.

[ghost]

Note @wolfmanjm just added laser power override to smoothieware too :) so getting queue jump to work means we can override feed and power (;

On Sep 2, 2016 9:32 PM, "Monte Krol" notifications@github.com wrote:

This seems like it's in my wheelhouse. I'll try to swing at this weekend.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-244467865, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr228uM9eAJ8isrU5cAnsJn84xxr-Mks5qmHnlgaJpZM4JmAaK .

[krolco]

@openhardwarecoza I think this is a different issue?

[ghost]

Oh shoot. Yes. Sorry! (:

On Sep 2, 2016 9:36 PM, "Monte Krol" notifications@github.com wrote:

@openhardwarecoza https://github.com/openhardwarecoza I think this is a different issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-244468711, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr21CYKiWSJrVpX50VQjYn7zBVUCSiks5qmHrKgaJpZM4JmAaK .

[ghost]

(; or maybe i was subconsciously hinting at priority hehe

On Sep 2, 2016 9:37 PM, wrote:

Oh shoot. Yes. Sorry! (:

On Sep 2, 2016 9:36 PM, "Monte Krol" notifications@github.com wrote:

@openhardwarecoza https://github.com/openhardwarecoza I think this is a different issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-244468711, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVr21CYKiWSJrVpX50VQjYn7zBVUCSiks5qmHrKgaJpZM4JmAaK .

[krolco]

LOL :)

[krolco]

Pull request is in for this -- @cojarbi, please give it a test after it's merge.

[cojarbi]

Thanks @krolco. BTW can we start a beer round for you? What's your PayPal.me?

[krolco]

LOL, not yet. :) Let me fix my introduced bugs first.

[cojarbi]

Set it up and send it to me please, our group supports every single developer.

On Wed, Sep 7, 2016 at 5:00 PM, Monte Krol notifications@github.com wrote:

LOL, not yet. :) Let me fix my introduced bugs first.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-245433123, or mute the thread https://github.com/notifications/unsubscribe-auth/APrsFp79mlnW02aX7cVRCVcBpdnOdpEfks5qnzPkgaJpZM4JmAaK .

Ariel Yahni

[cojarbi]

Is there anything in the GUI that will show this has been saved? I changed my jog speed, refresh but it doesnt stick or is it something esle?

[krolco]

Let me try it out. I saw it working on my setup, but maybe something else isn't working.

[krolco]

Ah, I think I didn't understand the request -- I made LW3 save the jog distance, (0.1/1/10/100mm) setting, and remember that between sessions, but not the jog speed. I can add that also.

[cojarbi]

Ohhh. Yes the speed gets reset on every browser refresh

AY

On Sep 9, 2016, 13:26, at 13:26, Monte Krol notifications@github.com wrote:

Ah, I think I didn't understand the request -- I made LW3 save the jog distance, (0.1/1/10/100mm) setting, and remember that between sessions, but not the jog speed. I can add that also.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-245998234

[krolco]

OK, I'll add that also. Sorry about the confusion!

[krolco]

I have this implemented with a "Save Jog speeds" button locally like this: https://1drv.ms/i/s!AhNJtMTn2rnyh3-A5Gt6hoJy3huM

Tell me what you think, and I can commit this.

[krolco]

I have an open pull request ( #127 ) that should implement this, if you like the save button.

[cojarbi]

It look good and fits. I imagine that Peters suggestion to just grab the last value on the field and use it is not possible? My original suggestion was to set it up on settings with the rest of them, thus manteining the same logic for the user.

Let's thinks for a minute, if I'm using one machine I'm most likely won't be changing the jog speed after I find the apropiate one. But what happens if I'm connecting to a laser and a CNC then the value could be the same or not?

Then again future machine profiles could solve this matter.

AY

On Sep 9, 2016, 17:13, at 17:13, Monte Krol notifications@github.com wrote:

I have this implemented with a "Save Jog speeds" button locally like this: https://1drv.ms/i/s!AhNJtMTn2rnyh3-A5Gt6hoJy3huM

Tell me what you think, and I can commit this.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-246055346

[krolco]

I could save the last value in the field; however it's less when you are done typing in a number; other parts of the app work that way, though, so I can change it to that system instead of a save button if you and Peter prefer. Let me know.

[krolco]

I meant "less clear". Other parts of the app a triggered on keyup, which means saving as you type. I'm not a fan of that, but that's just a preference.

[cojarbi]

I'm in favor of placing a default field in settings and then the user can change it as pleased. Make sense for me much more if we are getting profiles.

Let's wait for Peters opinion here

AY

On Sep 9, 2016, 18:07, at 18:07, Monte Krol notifications@github.com wrote:

I meant "less clear". Other parts of the app a triggered on keyup, which means saving as you type. I'm not a fan of that, but that's just a preference.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openhardwarecoza/LaserWeb3/issues/96#issuecomment-246065036

[krolco]

There is a default: it will default to 30/5 if you haven't ever changed settings; I left those defaults in. The difference is whether or not there is a save button, or whether we automatically try to save the setting when somebody types into the field.

I am testing a change right now that triggers off the Javascript "change" functionality: you can type a number in, but the "change" event isn't fired until the field loses focus, so the settings is saved when you either tab or click off the field.

There are a few other parts of the app that trigger off the "key up" event (like settings the offsets for raster and meshes); I'm not a huge fan of that, because it can cause conversion errors (for instance, if you're trying to type "300.0" and you've typed "300." that can fail text->number conversion. That's why I prefer the "change" trigger event, but it can sometimes causes unexpected behavior for users since it isn't fired until the field loses focus.

And I tried to skip all of that by just making it an explicit user action to click the save button. :) I am going to commit a version that uses "change". I think that it will act the same way Pronterface does (which was referenced in the original request for this item).

M

[krolco]

OK, I committed this without the save button, with automatic saving on change triggers. I'm going to merge it in this state, and it's just a little merge-fu if Peter decides he wants it the other way. I'm also going to close the other pull request.

[krolco]

128 should do this now. Please give it a spin.

[cojarbi]

Confirmed Thanks