LaserWeb / lw.comm-server

Unified communications server for LaserWeb4 (and other frontends)
GNU General Public License v3.0
38 stars 47 forks source link

FEATURE: implementing jogCancel command for live jogging #73

Open ibrahimuslu opened 5 years ago

ibrahimuslu commented 5 years ago

Hello,

for the live jogging grblv1.1 implemented a jogcancel command with extended ascii commands I have implemented it for arduino grblv1.1 but i dont know which commands for the other firmwares.

      appSocket.on('jogCancel', function () {
        writeLog(chalk.red('Jog Cancel'), 1);
        if (isConnected) {
            writeLog('Jog canceled and queue cleared', 1);
            switch (firmware) {
            case 'grbl':
                machineSend(String.fromCharCode(0x85))
                writeLog('Sent: Code(0x85)', 2);
                break;
            default:
                writeLog(chalk.red('ERROR: ') + chalk.blue('Unknown firmware!'), 1);
                break;
            }
        } else {
            io.sockets.emit("connectStatus", 'closed');
            io.sockets.emit('connectStatus', 'Connect');
            writeLog(chalk.red('ERROR: ') + chalk.blue('Machine connection not open!'), 1);
        }
    });
cprezzi commented 5 years ago

I don't see the need for "jogCancel". Why not just use "resetMachine"? This can be quickly issued by pressing ctrl-x from the frontend.

ibrahimuslu commented 5 years ago

Let me explain. We are trying to use in lw.com.server and developing a new touch screen ui. jogcancel is stopping immediately the jog operation. there is no ctrl+x on touch screen. on the live jogging we are trying to implement jogging while pressing the button and stop jogging when you stop pressing. There is no other option that i could find to stop jogging immedieately and enter to idle mod.