Laskyyy / Create-Astral

Other
70 stars 61 forks source link

Blocks from CC:Tweaked vanishing #190

Open themoiFR opened 1 year ago

themoiFR commented 1 year ago

Hello,

I started playing with Astral for a while with two saves : one is survival and one is creative. Recently, on my survival world, turtles and computers from CC:tweaked disapeared when loading the save. I first thought it was the save that was corrupted because I do not have this issue with my creative save. So I created a new survival save : same issue. I also tryed to reinstall the modpack : nothing changed

I attached the last log, don't know if it can help

latest.log

Laskyyy commented 1 year ago

CC on the version we use current;ly has a singleplayer issue where autosaves seem to fail to save any chunks where a computercraft block is present. As far as I know waiting longer than 10s or so in the pause menu before quitting stops it from happening but its currently something known, and the CC devs have stated they won't backport the fix to 1.18.2.

I've tried to revert to an older CC version and confirmed that it fixes the issue, but then further issues arise with major rendering errors with iris whenever monitors are present within the world.

themoiFR commented 1 year ago

Ok so it is going to stay this way ? Not a really big deal, I won't use CC in my maps

Giraaffes commented 1 year ago

For anyone who wants a quick fix for this, I've forked the current version of CC: Restitched and added a check when unloading computers so chunks won't fail to load (like in https://github.com/cc-tweaked/CC-Tweaked/commit/2fe40f669d490a42c84e2377c6e49aaaeeabfc25). A release is available there.

MaerkR commented 1 year ago

The mod should probably get removed until this gets fixed, I've spent a lot of time trying to figure out why my contraptions kept disappearing and only came across this now, or at least add a tooltip to CC computers to warn players

Erdragh commented 1 year ago

For anyone who wants a quick fix for this, I've forked the current version of CC: Restitched and added a check when unloading computers so chunks won't fail to load (like in https://github.com/cc-tweaked/CC-Tweaked/commit/2fe40f669d490a42c84e2377c6e49aaaeeabfc25). A release is available there.

I assume you've put up a Pull Request?

Giraaffes commented 1 year ago

For anyone who wants a quick fix for this, I've forked the current version of CC: Restitched and added a check when unloading computers so chunks won't fail to load (like in cc-tweaked/CC-Tweaked@2fe40f6). A release is available there.

I assume you've put up a Pull Request?

As far as I know you can't have custom mod jars in public CurseForge modpacks. Of course I could make a pull request in CC: Restitched, but I don't think the way I've managed to fix it is a very good way of doing it. Besides, a lot of people have already mentioned this in CC:R issues.

Erdragh commented 1 year ago

Being able to put customized jars in the pack depends on the license iirc, so we could try. Also, just opening a PR won't hurt. Worst case scenario it gets rejected. Best case scenario this issue is resolved.

Giraaffes commented 1 year ago

Being able to put customized jars in the pack depends on the license iirc, so we could try. Also, just opening a PR won't hurt. Worst case scenario it gets rejected. Best case scenario this issue is resolved.

That's true, I've opened a pull request now.

If you can figure out a way to put a custom jar in the pack, that would be brilliant, as computers are basically unusable right now. I have no clue how that would be done though.