search

Laskyyy / Create-Astral

Other
70 stars 62 forks source link

Bump mod versions and fix standalone server #292

Closed nicholasgrose closed 5 months ago

nicholasgrose commented 5 months ago

This is a copy of #291 except that I am splitting it off from my main dev branch to support continued experimentation. I'll simply cherry pick fixes into it.

This contains several notable changes:

  1. Added .idea to ignore files.
  2. Updates packwiz and adds a linux executable for it
  3. Updates many mods (via packwiz update command), including Fabric

Notable exceptions to the updates:

  1. Iris was updated from 1.6.6 to 1.6.10, rather than 1.6.11. 1.6.11 is unable to initialize, and my investigation has been unable to turn up why this is. It appears to be something to do with mixins, but more research is needed.
  2. Left REI at the current version because newer versions experience a crash when viewing some recipes. (Reproduced by pressing "U" on normal crafting tables. The crash might have been related to YTTR?)
  3. Updated to a nightly build of CreateBigCannons due to this bug
  4. Updated to a self-compiled nightly build of iris-flywheel-compat due to this commit that fixes it for Create 0.5.1c+.
  5. Updated to a self-compiled, self-modified build of Automobility to address this bug. This bug prevents dedicated servers from running, and it was an absolute pain to fix. The steps taken to resolve it involved recompiling an older version of ARRP (MPL-2.0 License) that supports 1.18.2 (0.5.5 no longer exists on Maven) and making the following change to the source code of Automobility (MIT License): image
nicholasgrose commented 5 months ago

Can you justify adding the .idea contents? Especially for specific plugins and deployment?

Not particularly. That was just inattentiveness. That's now been reverted and it is just gitignored. The PR description has been revised to mention REI.

Erdragh commented 1 week ago

Hey @nicholasgrose in case you're still around, we're having another server side issue with Automobility, namely that it crashes whenever you place anything from the mod... Are your changes to Automobility pushed somewhere?

nicholasgrose commented 1 week ago

Unfortunately, they are not currently pushed, but I can do so next week, when I'm back from travelling.

Hey @nicholasgrose in case you're still around, we're having another server side issue with Automobility, namely that it crashes whenever you place anything from the mod... Are your changes to Automobility pushed somewhere?

Erdragh commented 1 week ago

Actually, don't worry about it, I fixed it already. Had to remove some more @Environment annotations. Thanks for thoroughly documenting what you did!

nicholasgrose commented 1 week ago

Actually, don't worry about it, I fixed it already. Had to remove some more @Environment annotations. Thanks for thoroughly documenting what you did!

I'm glad to hear it!

Erdragh commented 1 day ago

Another thing, the Issue link for Big Cannons leads to a 404, can you recall what that was about? @nicholasgrose

nicholasgrose commented 1 day ago

Another thing, the Issue link for Big Cannons leads to a 404, can you recall what that was about? @nicholasgrose

I don't. However, I do know that the most recent patch version came out not long after I picked up the nightly. It would have whatever the fix was included.

Erdragh commented 1 day ago

Ah, great. Also, archive.org seems to actually have had a capture of that issue, once: https://web.archive.org/web/20240421151437/https://github.com/Cannoneers-of-Create/CreateBigCannons/issues/521