search

Last-Order / Minyami-chrome-extension

Chrome Extension for https://github.com/Last-Order/Minyami
37 stars 13 forks source link

Fix: add single quotes to escape pwsh call operator #17

Closed tuzi3040 closed 4 years ago

tuzi3040 commented 4 years ago

& is treated as a call operator in pwsh. This commit escapes it by adding single quotes '. & may also be escaped by using three double quotes """ or adding --% in front of arguments to prevent pwsh to expand args, though which may not be fully compatible with MS Command or Linux Shell.

Last-Order commented 4 years ago

Is this compatible with cmd and bash shell? Have you tested it?

tuzi3040 commented 4 years ago

Is this compatible with cmd and bash shell? Have you tested it?

It's ok with pwsh core@7.0.3, cmd on my win notebook and zsh/bash/sh on my mbp. I'm not sure if it is compatible with sth like fish which is not Bourne shell like.

Last-Order commented 4 years ago

LGTM, thank you.

Last-Order commented 4 years ago

Landed in 1.1.19

Last-Order commented 4 years ago

I'll revert this because some users reported that this is incompatible with cmd.