search

Last-Order / Minyami

A lovely video downloader for HLS videos
GNU General Public License v3.0
561 stars 37 forks source link

Fix local m3u8 + remote resource case #79

Closed fireattack closed 3 years ago

fireattack commented 3 years ago

Fix #78, a regression caused by #72.

Note: this does not handle (nor did it before) cases like local m3u8 URI + local resource URI, maybe a TODO

climba03003 commented 3 years ago

Thanks for the fast PR fix.

fireattack commented 3 years ago

(By the way, I don't think we need import { URL } from "url"; anymore; "The class is now available on the global object" since node v10.)

Last-Order commented 3 years ago

Thank you.

Last-Order commented 3 years ago

The fix has been landed in 4.2.3. Please note that loading local m3u8 files is a legacy feature and it's limited supported. If you have any other problems, please feel free to file a new issue.

climba03003 commented 3 years ago

The fix has been landed in 4.2.3. Please note that loading local m3u8 files is a legacy feature and it's limited supported. If you have any other problems, please feel free to file a new issue.

@Last-Order Sorry for bordering you, but 4.2.3 is not uploaded the correct build asset. dist/utils/common.js is the old one.

Last-Order commented 3 years ago

@climba03003 Sorry for that. It should be fixed in 4.2.4.