search

Lattice-Automation / seqviz

a JavaScript DNA, RNA, and protein sequence viewer
https://tools.latticeautomation.com/seqviz
MIT License
247 stars 53 forks source link

Configuration option to disable loading fonts from Google Fonts #226

Closed jcxldn closed 1 year ago

jcxldn commented 1 year ago

Hi,

We are developing a team wiki for our iGEM team this year. However, team wikis are not permitted to access external resources, such as Google Fonts. To mitigate this we have added an optional configuration option that disabled font loading from Google Fonts, allowing the developer to provide the fonts manually (in this case hosted on iGEM servers)

I think this would be beneficial to upstream for the benefit of others encountering this use-case (especially within the competition in the following years)

Thanks,

James

jjti commented 1 year ago

This looks great and makes sense to me. I'm gonna merge but make a small flip to make it disableExternalFonts (so default/unset == false, don't disable)

@jcxldn I think it's cool you managed to use this lib for iGEM. I was in iGEM but couldn't program at the time (and would've forgotten all details by now anyway).

Do you mind sharing how you made it work or could you share a short snippet/how-to so future teams can also use SeqViz?

jcxldn commented 1 year ago

Sure, I can write something up when I have time. Thank you!