RHMC cleanup - Githubissues

LatticeQCD / SIMULATeQCD

SIMULATeQCD is a multi-GPU Lattice QCD framework that makes it easy for physicists to implement lattice QCD formulas while still providing competitive performance.

https://latticeqcd.github.io/SIMULATeQCD/

MIT License

30 stars 12 forks source link

RHMC cleanup #122

Open clarkedavida opened 1 year ago

clarkedavida commented 1 year ago

[x] Formatting makes hisq smearing and force modules and associated files difficult to read. Should be cleaned up.
[ ] DSlash has HisqMdaggMFunctor which is not used anywhere? Should be deleted, since one would guess the applyMdaggerM method calls it, but it doesn't.
[x] hisqforceconstructs header has a hisqforce include guard. Meanwhile hisqforce.h has no include guard. Can be fixed with #101

I may add more things. I'm cleaning up the formatting stuff right now while adding some documentation, but the other changes require testing so I'm going to postpone them to a different commit.

clarkedavida commented 1 year ago

[ ] The HisqSmearing class has a smearAll method carrying out the level 1 hisq smear, unitarization, and level 2 smear. Separately is class has a SmearLvl1 method and a ProjectU3 method, apparently because they are used in the force. Would it make sense to have the smearAll method call these two, to reduce code redundancy?

clarkedavida commented 1 year ago

[ ] There is a "SHARED_GAUGENAIK", which is only shared between level 1 smearing fields. It is also shared with a gaugeNaik field in the Force profiler... I guess this should be renamed?
[ ] Along this vein, the force profiler is apparently quite outdated by now. Maybe we should just axe it?

clarkedavida commented 1 year ago

    //this is only a placeholder function for testing, real implementation is in HISQ force! REMOVE for production!
    void make_f0(Spinorfield<floatT, onDevice, Even, HaloDepthSpin> &phi, std::vector <floatT> rat_coeff);

This is in our integrator.h... What do I do?

I'm adding a bunch of you guys b/c I want your perspectives on some of the stuff I'm putting in here.

clarkedavida commented 1 year ago

[x] both plaqconstructs.h and rectconstructs.h have the same include-guard... how is this possible? Lukas you wrote these, do you know what happened?