Bug with RHMC parameters passed as argument

LatticeQCD / SIMULATeQCD

SIMULATeQCD is a multi-GPU Lattice QCD framework that makes it easy for physicists to implement lattice QCD formulas while still providing competitive performance.

https://latticeqcd.github.io/SIMULATeQCD/

MIT License

29 stars 11 forks source link

Bug with RHMC parameters passed as argument #50

Closed clarkedavida closed 2 years ago

clarkedavida commented 2 years ago

It seems that if you try to pass an RHMC parameter file as an argument, SIMULATeQCD will ignore it. This is inconvenient and not intended...

clarkedavida commented 2 years ago

There also apparently is an issue that parameter names are wrong. Maybe one can throw an error if an unrecognized parameter is wrong.

clarkedavida commented 2 years ago

The first issue can be solved by passing argc and argv as well.

[ ] add to documentation
[x] fix hisqforce, condensate, and rhmc tests
[ ] implement multigpu tests for these in the test scripts

lukas-mazur commented 2 years ago

Related to this issue: These tests don't have a default parameter file:

main_DslashImagmuTest.cu
main_RndMultipleTest.cu
main_hisqSmearingMulti.cu
main_HBOR_single_test.cu

So a line such as

 param.readfile(commBase, "../parameter/tests/<testname>.param", argc, argv);

is missing.

luhuhis commented 2 years ago

Was this partly resolved with #52 ?