search

Lattyware / elm-fontawesome

FontAwesome for Elm.
https://package.elm-lang.org/packages/lattyware/elm-fontawesome/latest/
MIT License
33 stars 6 forks source link

Possible fix for #15 #16

Closed leojpod closed 3 months ago

leojpod commented 3 months ago

Possible fix for #15.

As I couldn't see what was wrong, I thought to ask elm-json to reinstall the dependencies and see if it would come up with something different. It does seem to restrict a bit the version of elm/core which might deal with the dependency issue reported in #15.

CharlonTank commented 3 months ago

I think it doesn't cost anything to deploy this version anyway ;)

Lattyware commented 3 months ago

This repo is generated, so I made the change upstream in the generator and main now has this change in.

CharlonTank commented 3 months ago

Thank you!

I still get this error, I will try to build it myself and see.

Lattyware commented 3 months ago

Thank you!

I still get this error, I will try to build it myself and see.

I may have misunderstood, were you getting this error trying to use the package directly from the Elm repo? If so I'll need to publish a new version to fix it, although again I can't reproduce.

Could you give an example of exactly what you were trying to do to get the error? I'll reopen #15

leojpod commented 3 months ago

@Lattyware I tried to use your module in an elm-pages project, it "installed" successfully but when compiling it showed the error. At first I thought it was lamdera shenanigans but I've tried to build the part of the project that uses it with elm make and got the same issue.

leojpod commented 3 months ago

I may have misunderstood, were you getting this error trying to use the package directly from the Elm repo? If so I'll need to publish a new version to fix it, although again I can't reproduce.

Originally yes I was getting it from there. when I tried with the "fixed" dependencies that error went away. I got another error though, but that one I think might be only lamdera related and I haven't inspected it further for now.