search

LauJensen / clojureql

ClojureQL is superior SQL integration for Clojure
https://clojureql.sabrecms.com
Eclipse Public License 1.0
285 stars 39 forks source link

with-results should take a binding vector instead of two symbols #16

Closed oranenj closed 13 years ago

oranenj commented 13 years ago

with-results is inconsistent with similar core operators, which always take a vector when they create new (local) bindings. Since 1.0.0 is still beta, I hope this wart can be fixed. :)

That is, instead of (with-results tbl rs ...) it should be (with-results [tbl rs] ...).

This would also enable binding several tables to several result sequences in one go.

I didn't check if there are other operators like with-results, but of course those should be changed too.

LauJensen commented 13 years ago

Sure I agree, I'll fix this ASAP.

Thanks Lau

LauJensen commented 13 years ago

Fixed https://github.com/LauJensen/clojureql/commit/804c3a2b9d9f34da2ae8cd04c56b3deb4c297a09

Thanks for raising it! Lau