search

LauJensen / clojureql

ClojureQL is superior SQL integration for Clojure
https://clojureql.sabrecms.com
Eclipse Public License 1.0
285 stars 39 forks source link

The update-in! fn generates "(id IS 'NULL')" instead of "(id IS NULL)". #22

Closed r0man closed 13 years ago

r0man commented 13 years ago

Hi Lau,

I'm trying to use the beta 2 version of clojureql for some of my queries. Just found a bug that was caused by the update-in! fn when using nil values. The fn was generating "(id IS 'NULL')" instead of "(id IS NULL)". This was not caused by the fn itself. With the parameterization of args the sanitize fn should not handle the conversion of nil values anymore, because otherwise it would be double escapes (or converted). I fixed this and added some tests. I think the same applies when compiling (=* nil nil) => ["TRUE" []]). I think it should be [true []], but I have to check this later ...

Greetings, Roman.

LauJensen commented 13 years ago

Hi,

I've fixed this for now, the hard way. I'll try and experiment a little and see if I cant leverage the nil/NULL unification instead of my current fix: https://github.com/LauJensen/clojureql/commit/b43f82bff6806539b0dab172399bc0c70bff7bcc