search

LauJensen / clojureql

ClojureQL is superior SQL integration for Clojure
https://clojureql.sabrecms.com
Eclipse Public License 1.0
285 stars 39 forks source link

Patch to allow connection info to be supplied as a function #36

Closed doooks closed 13 years ago

doooks commented 13 years ago

Hi guys.

Please consider accepting my patch to clojureql to allow the connection info to be supplied as a function. We need this to be able to use your library in our project since we do not know the connection info at compile time.

I like the look of the re-written library, we wanted to use it in our project before the rewrite but found being limited to two tables in a join was a showstopper. We hope to be able to make good use of query composition in your new version.

Anyway, let me know what you think of the patch. Cheers Dan Dukeson (doooks)

LauJensen commented 13 years ago

Hi Dan,

Thanks for checking out ClojureQL and even contributing. Im glad you like take-2 better than the first cut - so you should :)

The patch looks great so Ive merged it into master and released a new jar to clojars, so you can use that in your projects from now on.

Please let me know if you come across any show-stoppers or if things just work out for you guys, Thanks for the patch Lau

doooks commented 13 years ago

Fast turnaround! Thanks for that. Dan