search

LauJensen / clojureql

ClojureQL is superior SQL integration for Clojure
https://clojureql.sabrecms.com
Eclipse Public License 1.0
284 stars 39 forks source link

Support for 'in' clause #37

Closed l0st3d closed 13 years ago

l0st3d commented 13 years ago

Hey Guys,

I've added support for 'in' in where clauses because I needed it for a project. Hope that it's acceptable.

Ed

doooks commented 13 years ago

I could really use this too. Same project ;-) Dan

LauJensen commented 13 years ago

Hi Ed,

First off you should know that I really appreciate you pouring time and effort into this project.

As I was reviewing the code, it occurred to me, that the reason predicate.clj is so concise is because many of the primary operators are implemented using the defoperator, which basically compiles an infix predicate. IN is only different in the sense that its a prefix function, so I renamed defoperator -> definfixoperator and added defprefixoperator as well. That solved the issue and will hopefully make future prefix ops easier to implement. For that reason, I have decided not to merge your patch, but thanks a lot for getting the ball rolling!

Lau