search

LauJensen / clojureql

ClojureQL is superior SQL integration for Clojure
https://clojureql.sabrecms.com
Eclipse Public License 1.0
285 stars 39 forks source link

Fix to sort by field on table #38

Closed l0st3d closed 13 years ago

l0st3d commented 13 years ago

Hi guys,

I've fixed a bug in the way the sort column was specified, the table was always assumed to be the first one seen in the current query. I've changed the way the table name was prepended on to the field name, so that you can specify the table in the sort. It now looks for a "." in the field name and if it doesn't find one, it will prepend the table name as before, otherwise it assumes that you meant to put :tablename.fieldname and leaves it alone. Make sense.

Ta

LauJensen commented 13 years ago

Your 2 remaining pull requests are not correctedly separated into branches, meaning all of the functionality is now munged. Since we are still debating what to do with SORT (see broken tests in core.clj) I will close these 2 issues and we can resume this work once everything has been hashed out on IRC.

Thanks a lot, Lau