search

LauLamanApps / iZettleApi

iZettle Api php intergration
MIT License
12 stars 15 forks source link

Fixed image uploading. Both URL and a file #29

Closed korzol closed 5 years ago

korzol commented 5 years ago

Hello Thank you! You did a great job! iZettle updated their API documentation. At least new there is correct URL to send images to. Also some small changes like uuid in ImageClient was null. Also now they require image type even for url, so I had to implement it somehow

Have a good day

LauLaman commented 5 years ago

Great job! Can you also add in the changes in the tests?

This PR should fix #25 image bug

korzol commented 5 years ago

Will be glad but first I need to learn how it works and where to make changes :)

korzol commented 5 years ago

Added image upload to unit tests. But testing fails if I run it as is. Complain is:

Fatal error: Trait 'LauLamanApps\IzettleApi\Tests\Unit\MockeryAssertionTrait' not found in ..izettle/vendor/laulamanapps/izettle-api/tests/Unit/GuzzleIzettleClientTest.php on line 24

Checked path and namespaces, even added 

require_once 'MockeryAssertionTrait.php';

to GuzzleIzettleClientTest.php but seems nothing works.

PHP 7.2.15. iZettleApi has been installed with composer

Any thoughts ?

LauLaman commented 5 years ago

Hi @korzol Great job!

Can you tell me how you are running the tests? are you using the Make commands?

I've checkout your pr locally and have come to the following conclusion:

If you run with the make command it should work. You can also check if you have mockery installed in your vendor directory.

i've also left you some more feedback. 🤗

LauLaman commented 5 years ago

Hi @korzol

Are you able to finish this PR?

chatlumo commented 5 years ago

Hello @korzol,

Is there any news about this PR ?

LauLaman commented 5 years ago

Closed due to no response. i might fix this myself later on