search

LaunchCode-Education-Archived / csharp-web-development

Unit 2 (C# Track) of the LC101 Curriculum, following fundamentals in JavaScript
https://education.launchcode.org/csharp-web-development/
GNU General Public License v3.0
5 stars 9 forks source link

Chapter 1 Updates #70

Closed scottkuhl closed 3 years ago

scottkuhl commented 4 years ago

Here are my notes for Chapter 1. Mostly very small changes. Feel free to pick and choose the updates you want. You can find notes on individual commits on why I am making the suggestions.

scottkuhl commented 3 years ago

When all the conversations are resolved, would you like me to do a new pull request?

jimflores5 commented 3 years ago

Scott, After you push up the last round of edits, we'll just merge in the current PR. There's only a couple of outstanding comments for Chapter 1.

Thanks, Jim

On Sat, Feb 6, 2021 at 2:39 PM Scott Kuhl notifications@github.com wrote:

When all the conversations are resolved, would you like me to do a new pull request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaunchCodeEducation/csharp-web-development/pull/70#issuecomment-774540250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTEZLV6QZBX6ZOTRS2I4OLS5WSJFANCNFSM4OJR67JQ .

scottkuhl commented 3 years ago

I beleive I got all the changes. If you make another pass and noticed that I missed something let me know. Thanks.

jimflores5 commented 3 years ago

Scott, As always, thanks for your feedback! I merged in your chapter 1 edits this morning.

Regards, Jim

On Wed, Feb 10, 2021 at 6:30 PM Scott Kuhl notifications@github.com wrote:

I beleive I got all the changes. If you make another pass and noticed that I missed something let me know. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LaunchCodeEducation/csharp-web-development/pull/70#issuecomment-777132804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTEZLVPO4PTOCW2UBYJOZLS6MQJLANCNFSM4OJR67JQ .