search

LaunchPadLab / lp-components

Our Components
http://lp-components.herokuapp.com
MIT License
5 stars 1 forks source link

Make options and value required in TabBar #419

Closed chawes13 closed 2 years ago

chawes13 commented 4 years ago

v3.31.0 introduced an enhancement where the styling will be applied correctly to the first option (if any exist), but since this is a controlled input that doesn't really address the need in terms of functionality. a Tablist should always have a tab visible, so we should require that value is set. Related to that, options should be required as well because you can't really have a value set if there are no options

chawes13 commented 4 years ago

Note: this would be a breaking change, but could go in v4