Closed mwislek closed 4 years ago
@dpikt be brutal with your review! My confidence level is at 62.3% with this change.
@dpikt Documentation manually updated. Should be good to go.
Travis is jacked up for some reason. I'll merge.
Excellent. Thanks David!
M
From: David Pickart notifications@github.com Reply-To: LaunchPadLab/lp-components reply@reply.github.com Date: Tuesday, July 14, 2020 at 1:59 PM To: LaunchPadLab/lp-components lp-components@noreply.github.com Cc: Mike Wislek mike@launchpadlab.com, Author author@noreply.github.com Subject: Re: [LaunchPadLab/lp-components] Add valueGetter to Table component (#434)
Merged #434https://github.com/LaunchPadLab/lp-components/pull/434 into master.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LaunchPadLab/lp-components/pull/434#event-3545502700, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL236KNKXUFRNNJT2H6Y7P3R3STKTANCNFSM4OZW6LOA.
This PR adds a
valueGetter
prop to the<SortedTable>
component to facilitate creating columns whose data is derived, typically from multiple properties of a table row's data. ThevalueGetter
prop is a function that is passed row data and returns the derived data value.Author Checklist