search

LaunchPadLab / lp-components

Our Components
http://lp-components.herokuapp.com
MIT License
5 stars 1 forks source link

Table column does not sort correctly when using `valueGetter` #435

Closed dpikt closed 4 years ago

dpikt commented 4 years ago

Because it isn't passed to the underlying sortable instance.

This bug could be a good opportunity to get rid of that underlying dependency. (see #414)

cc @mwislek

dpikt commented 4 years ago

It seems like the component tests are pretty comprehensive so a refactor to hooks should be fairly safe. One exception is the initialAscending prop, so we should add a test for that as part of this fix.