Refactor table sort - Githubissues

LaunchPadLab / lp-components

Our Components

http://lp-components.herokuapp.com

MIT License

5 stars 1 forks source link

Refactor table sort #437

Closed mwislek closed 4 years ago

mwislek commented 4 years ago

This PR resolves the issue Table column does not sort correctly when using valueGetter by facilitating default sort when a valueGetter is specified. This PR also refactors the SortableTable component to use React hooks rather than the sortable HOC.

Author Checklist

[x] Add unit test(s)
[x] Update version in package.json
[ ] Update documentation (if necessary)
[x] Add story to storybook (if necessary)
[x] Assign dev reviewer

mwislek commented 4 years ago

@dpikt Not sure about the version number. This PR is a patch in the sense that it fixes a bug. But I did add tests (which were actually missing, not necessarily "new"). I chose a patch version. Lemme know what you think.

dpikt commented 4 years ago

Patch!

dpikt commented 4 years ago

@mwislek Ok, travis is back, merge at will!