search

LaunchPadLab / lp-components

Our Components
http://lp-components.herokuapp.com
MIT License
5 stars 1 forks source link

Made options & value as required for the TabBar component #461

Closed AngelMDev closed 2 years ago

AngelMDev commented 3 years ago

Addresses: #419.

This one I admit is a bit outside the area of my expertise, but I think these changes do the trick, assuming chaining isRequired works as I expect it to do. I guess one question that I have is if the linter is supposed to catch these, or if an error is supposed to print in dev console? I certainly saw none of these for both of the params, while other components do show a linter error. Lmk if I needed to do anything else here for that to show.

Bumping to a new major version.

chawes13 commented 2 years ago

@AngelMDev Do you have any bandwidth to make these adjustments?

AngelMDev commented 2 years ago

@AngelMDev Do you have any bandwidth to make these adjustments?

Sorry, this has been off my radar for a really long time! Yes I can address this. On the upside, I now have a better idea of what I'm doing hah.