Closed chawes13 closed 2 years ago
Makes sense to me!
Relatedly, it would be nice to pass down props specifically to each checkbox. For example, a custom labelComponent
. Thinking an api could look like checkboxProps
. I'll try this out on CDK before porting it over
Currently, passing in the
className
prop to a field that uses theCheckboxGroup
component will override theclassName
prop on the outer fieldset, as well as the fieldset for each individual checkbox. This isn't ideal, since our base styling relies onCheckboxGroup
andcheckbox
classes to exist on these fieldsets and it makes it harder to target the outer element. Since we can target the checkbox fieldsets via nesting, I'd propose that only the outer fieldset have the class name applied.Proposed
Current