Remove lp hoc - Githubissues

LaunchPadLab / lp-components

Our Components

http://lp-components.herokuapp.com

MIT License

5 stars 1 forks source link

Remove lp hoc #562

Closed chawes13 closed 2 years ago

chawes13 commented 2 years ago

Resolves #414

Author Checklist

[X] Add unit test(s)
[ ] Update version in package.json (see the versioning guidelines)
[x] Update documentation (if necessary)
[ ] Add story to storybook (if necessary)
[x] Assign dev reviewer

chawes13 commented 2 years ago

@mwislek I totally forgot to add documentation about the inversion of control approach I took which now requires an apiAdapter prop!!! I'm going to pull this back into draft and then will re-request your review. The reason that I did this is because I did not want to pull in lp-requests as a dependency to this library. Someone could pass in axios or really any object that responds with a Promise to .post().

For reference: new approach vs. existing approach

chawes13 commented 2 years ago

@mwislek Ready for review again. Here are the latest changes: https://github.com/LaunchPadLab/lp-components/pull/562/files/159e092c63244b4ef8efb0db13f9c4218dc3226f..68d2c649f98db1f4dc7b789cf6fb5a60d79d09f6