Closed josiasds closed 9 months ago
@chawes13 I updated all the files currently in this PR and addressed all comments. Let me know your thoughts, and then we can merge the separate PRs into this branch.
@josiasds I merged the latest release on main
into and migrated color picker tests. LMK what else you need from me!
@chawes13 I can't approve this PR since I'm the author, but it's ready!
Thanks @josiasds! I want to fix the test coverage regression before we officially go-live with this. I'll tackle that first thing when I'm back 🙂
@chawes13 I just reviewed your latest changes, looking good. Mocking isServer
is the best approach in my opinion.
@josiasds Ready for ya! We got to 100% coverage 😎
This PR contains the migration from
enzyme
toreact-testing-library
, as requested in #567.From the docs:
Release Notes
Author Checklist
Enzyme
(and adapter) libs and setupComponents to migrate:
[x]
/controls
(#602)paginator
color-picker
(depends on #596)tab-bar
[x]
/forms
/buttons
(in review in this PR #586)button-area
button
submit-button
/labels
(#607)error-label
input-error
input-label
labeled-field
/inputs
cloudinary-uploader
checkbox-group
checkbox
cloudinary-file-input
(#590)color-input
date-input
dropdown-checkbox-group
file-input
(#590)hidden-input
icon-input
input
masked-input
radio-group
range-input
select
switch
textarea
[x]
/indicators
(#600)flash-message-container
flash-message
loading-container
spinner
(in review in this PR)[x]
/tables
(#603)sortable-table
table-column
table
[x]
modal
(#601)[x] Add unit test(s)
[x] Update version in package.json (see the versioning guidelines)
[ ] Update documentation (if necessary)
[ ] Add story to storybook (if necessary)
[x] Assign dev reviewer