Hotfix: button variant story

[chawes13]

Resolves #629

QA Steps

• Checkout branch locally
• Run yarn storybook
• [x] Button variant: small story loads

Author Checklist

• [ ] Add unit test(s)
• [x] Update version in package.json (see the versioning guidelines)
• [ ] Update documentation (if necessary)
• [x] Add story to storybook (if necessary)
• [x] Assign dev reviewer

[chawes13]

@JoseWhite Got a few minutes to review this PR this week? Would love to get it in soon, thanks!

[JoseWhite]

Loaded the app locally and it renders correctly 👍 I was thinking if it would make sense to add a jest spec for it, something like the snippet below to the button.test.js file.:

test('Button variant: small renders correctly', () => {
  render(
    <Button type="button" style={{ variant: 'small' }} >
    Submit
  </Button>
  )
  const button = screen.getByRole('button')

  expect(button).toBeVisible()
})

I looked into testing storybook stories and found this jest add-on for storybook, it allows seeing test results in the storybook itself, perhaps it could make it easier to catch/prevent issues like this in the future.

[chawes13]

Loaded the app locally and it renders correctly 👍 I was thinking if it would make sense to add a jest spec for it, something like the snippet below to the button.test.js file.:

test('Button variant: small renders correctly', () => {
  render(
    <Button type="button" style={{ variant: 'small' }} >
    Submit
  </Button>
  )
  const button = screen.getByRole('button')

  expect(button).toBeVisible()
})

I looked into testing storybook stories and found this jest add-on for storybook, it allows seeing test results in the storybook itself, perhaps it could make it easier to catch/prevent issues like this in the future.

We have a test for this! https://github.com/LaunchPadLab/lp-components/blob/bd1d293618fbe44fa07187863d9d28e2e1cc7f1a/test/forms/buttons/button.test.js#L89-L94

The jest add-on is interesting, thanks for sharing! I'm not sold on the value of including it – it wouldn't have prevented this issue here where the story was using an older syntax than the component/tests.