Accessibility issues with LabeledField Stories - Githubissues

LaunchPadLab / lp-components

Our Components

http://lp-components.herokuapp.com

MIT License

5 stars 1 forks source link

Accessibility issues with LabeledField Stories #632

Closed danparnella closed 3 months ago

danparnella commented 5 months ago

Environment

@launchpad/lp-components version: 9.3.1
react version: 18
node version: 18.12.1

Expected Behavior

There wouldn't be accessibility issues related to form field labels when loading up the Storybook and looking at the stories for LabeledField

Current Behavior

Looks like there are a few issues with form inputs not having labels (seems like a problem we want to make sure doesn't exist in our examples for a field with a label 😅)
Pointed out in: https://github.com/LaunchPadLab/lp-components/pull/595#discussion_r1443518178

Steps to Reproduce

Can be seen in the deployed storybook: http://lp-components.herokuapp.com/
Open up and click on the stories for LabeledField
Click on the Accessibility tab in the "addons" section to see the issues

Suggested Solution

I think the Input in the stories just needs the name from the LabeledField also passed into it as it's id