search

LaunchPadLab / lp-utils

Our Utilities
MIT License
1 stars 0 forks source link

Update onLoad docs #21

Closed bhennes2 closed 7 years ago

bhennes2 commented 7 years ago

@dpikt This was mostly a copy past exercise. I'd like to sit down tomorrow morning to review and understand the use case for the function.

Are you free tomorrow morning?

dpikt commented 7 years ago

@bhennes2 for sure!

dpikt commented 7 years ago

Added to calendar for this afternoon.

bhennes2 commented 7 years ago

@dpikt Feel free to review again. I'm not that confident in my example so feel free to provide direct comments on it. Thanks!

bhennes2 commented 7 years ago

@dpikt Feel free to take another look. Getting warmer!

bhennes2 commented 7 years ago

@dpikt I took another shot at this per your feedback: "Type explanations are still a little unclear- it’s not immediately apparent that a string is the name of a prop to wait for, or the object is an object of prop names and expected values. I think it would suffice to explain the intuition behind the params rather than their exact behavior if that makes sense"

I feel like I "did" that but probably in an awkward way. If you want to just make your final edits to my copy I'm good with that. Since I haven't actually used the onLoad HOC before in my code my understanding of its idiosyncracies is limited.

dpikt commented 7 years ago

@bhennes2 sounds good. Thanks for bearing with this PR, I know it's a little arduous but hopefully it's been helpful for getting acquainted with the react HOC pattern 👍

bhennes2 commented 7 years ago

@dpikt All good. Thanks for the help!