LaunchPadLab / lp-utils

Our Utilities
MIT License
1 stars 0 forks source link

Improve selectorForSlice #55

Closed dpikt closed 7 years ago

dpikt commented 7 years ago
rkillackey commented 7 years ago

@dpikt Not sure I understand the last bullet point here. Couldn't you just give the full path including the "post-path slice"?

dpikt commented 7 years ago

Yeah it's not really necessary. I was just brainstorming. Most of our selectors on kubo look like this:

const selectors = {
    facilities: select('facilities.success'),
    patients: select('patients.success'),
    surveys: select('surveys.success'),
}

so I thought it might be nice to remove some of that redundancy. I would just shelve the idea for now though, since it's not really a big issue.

rkillackey commented 7 years ago

Ohh, gotcha. Do you want to open a new issue for the backlog?

dpikt commented 7 years ago

Eh I would just ignore it for now. I don't really see it popping up again tbh