search

Laupetin / OpenAssetTools

Open Source Modding Tools for old Call Of Duty games
https://openassettools.dev
GNU General Public License v3.0
97 stars 13 forks source link

Tools: consider removing premake files from repo under tools/ #243

Open diamante0018 opened 2 months ago

diamante0018 commented 2 months ago

It's probably better that the end user has premake installed on their system somewhere and adds it to their path env

this eliminates the need to distribute premake5 binaries inside the repo

this is a similar choice I've taken when dealing with alterware's clients repo https://git.alterware.dev/alterware/iw4x-sp#build

Laupetin commented 2 months ago

Definitely something that i want to address in the future. I don't like the opaque binaries in the repository either.

The issue is that premake is not exactly easy to install because you must choose the containing folder yourself and add it to the path manually. There is no automated installation process to do this. This somewhat adds a barrier to compiling the project for more inexperienced developers.

What I could imagine is adding ontop of the generate.bat script to check whether a premake5 binary is in the path. If it is not it could download the latest version (after a confirmation prompt) and add it to a folder similar to the current one. That way it would not be in the repo but users would not need to manually install premake either.