LauraWebdev / GodotSteam_CSharpBindings

GodotSteam C# Bindings
MIT License
49 stars 6 forks source link

Type/Class cleanup: Steam.Input.cs #8

Closed LauraWebdev closed 3 months ago

Formedras commented 7 months ago

Multiple functions in Steam.Input.cs request handles in the form of signed long values. In all cases, the correct type to send is an unsigned long.

In addition, the "flags" arguments, such as in GetGlyphSVGForActionOrigin, should be corresponding enums with the [Flags] property. (For GetGlyphSVGForActionOrigin and GetGlyphPNGForActionOrigin, for example, the GDScript enum is Steam.InputGlyphStyle. Note that GDScript enums don't work properly as bitflags, so combining them in GDScript will cause warnings to appear. For these bindings, it's probably best to request arguments as flags, and then cast back to ulong for the call to GDScript.)