LaurenceRawlings / savify

Download Spotify songs to mp3 with full metadata and cover art!
MIT License
1.19k stars 80 forks source link

Grouping not working in .bat files #10

Closed FGameCZ closed 3 years ago

FGameCZ commented 3 years ago

Description

I tried to make a .bat file to make downloading easier, but it didn't work.

I made a .bat file looking like this:

@ECHO OFF
echo Please paste the song link
set/p "link=> "
cd C:/savify-dl
savify "link" -q best -f mp3 -g "%artist%/%album%" -o "C:\Users\xxx\Music\Spotify"
pause

And I got this error:
Error: Invalid value for '-g' / '--group': Group must be in the form x or x/x/x... where x in [%artist%, %album%, %playlist%]

Thanks

alexandrus21a commented 3 years ago

Hi, i have a same problem and delete from code %

if /i "%envrimet%" == "2" savify "%url%" -q 192k -f mp3 -o "D:/ЗАГРУЗКИ/ytmdl" -g "artist/album" and work for me. I think author fix this problem

FGameCZ commented 3 years ago

Hi, i have a same problem and delete from code %

if /i "%envrimet%" == "2" savify "%url%" -q 192k -f mp3 -o "D:/ЗАГРУЗКИ/ytmdl" -g "artist/album" and work for me. I think author fix this problem

Hi, thank you for answering me, but deleting "%" from code doesn't work for me.

alexandrus21a commented 3 years ago

Hi, i have a same problem and delete from code %

if /i "%envrimet%" == "2" savify "%url%" -q 192k -f mp3 -o "D:/ЗАГРУЗКИ/ytmdl" -g "artist/album" and work for me. I think author fix this problem

Hi, thank you for answering me, but deleting "%" from code doesn't work for me.

Hi, maybe I forgot to say where to remove%

you need to open this file \path-to-python\Lib\site-packages\savify\ and open the cli.py and change line 32 regex = r"^((artist|album|%playlist%)(\/(artist|album|%playlist%))*)+$" If you want to download song with playlist int bat use them regex = r"^((artist|album|playlist)(\/(artist|album|playlist))*)+$" Finally save file as cli.py and smile.

FGameCZ commented 3 years ago

Hi, Thanks for replying me. It didn't work for me, but I think, that I know where is the problem. I am using savify.exe.

FGameCZ commented 3 years ago

I have tried using python version and it works! Thank you.

FGameCZ commented 3 years ago

Sorry, but I just thought it is working. It just downloaded songs to folder "album" in folder "artist". Any other ideas?

LaurenceRawlings commented 3 years ago

I'm not sure which version you were using but this has been fixed in the latest version. The problem was that the %'s were missing, not that they should've been removed. Feel free to reopen if this is still an issue for you.