LaurenceRawlings / savify

Download Spotify songs to mp3 with full metadata and cover art!
MIT License
1.19k stars 80 forks source link

[FEATURE] Skip ffmpeg #38

Open radujica opened 3 years ago

radujica commented 3 years ago

Is your feature request related to a problem? Please describe. I'm looking for the best quality audio, so no conversion please. Perhaps could just restrict the format by passing an arg to youtube-dl e.g. "-f bestaudio[ext=m4a]" but still, need to disable the ffmpeg branch somehow.

Describe the solution you'd like An argument to skip conversion with ffmpeg, e.g. --raw? or --no-convert?

Describe alternatives you've considered Using raw youtube-dl or pafy. But I like the metadata handling you do here!

Additional context Add any other context or screenshots about the feature request here.

Edit: An afterthought is that ID3v2 is probably not supported for all audio formats, so perhaps extra checks are required to e.g. forbid downloading an audio version which cannot have ID3v2 tags or perhaps skip adding them if audio format does not support it. But I think mp3 and mp4/m4a should be fine.

trojblue commented 3 years ago

I'm using savify -q best -f flac and it's downloading at 16bit/44.1khz, sometimes 24bit/48khz. Should work good enough