search

LaurensWeyn / Spark-Reader

A tool to assist non-naitive speakers in reading Japanese
GNU General Public License v3.0
30 stars 7 forks source link

Initial reimplementation of FrequencySink logic #23

Closed wareya closed 6 years ago

wareya commented 6 years ago

If you don't like the changes I made to Spelling let me know and I'll change it somehow.

I say "initial" because I haven't given it the same testing the last implementation had.

wareya commented 6 years ago

I added another commit, if you don't want those changes pull the first commit alone manually instead of merging through github.

LaurensWeyn commented 6 years ago

Yea, instances no longer pointed to are collected whenever the JVM feels like it. The JVM also prepares memory for when the program needs to make new objects. It's best to take averages and/or use a profiler.

It's a small difference for sure, I'll worry about it later.