search

LaurentMarchelli / Baikal-DSM

Synology DSM installable package for Baïkal CalDAV & CardDAV server
GNU General Public License v3.0
1 stars 0 forks source link

large photo attributes make Baikal drop the connection #3

Open maichai opened 4 years ago

maichai commented 4 years ago

Baikal version: 0.4.6 on Synology DSM 6.2.2

Expected behaviour: if the Baikal server has an empty address book, when connecting the address book (e.g. using macOS app Contacts), and after importing hundreds of contacts, it is expected that all contacts are synced from e.g. macOS Contacts to Baikal server

Current behaviour: in the above scenario only a small fraction of the contacts (something between 80-260) are synced quite fast, then the syncing does not progress any more. The reason was isolated to vCards that contain large picture files. It seems that Baikal is not able to process large PHOTO attributes.

Steps to reproduce:

Install Baikal SKP 
Configure Baikal and set 1 user with 1 address book
Add this user account to e.g. macOS Contacts app
Import a vCard file including several contacts into the account in e.g. macOS Contacts
Upload a large picture file as contact photo into one contact
Select all contacts in e.g. macOS Contacts and export as vCard file
Modify the script https://github.com/ljanyst/carddav-util to do card.prettyPrint() if an upload exception occurs
Use carddav-util to upload the vCard file to Baikal 
See the upload throw an exception due to connection loss and print the vCard with the large picture
LaurentMarchelli commented 3 years ago

Hi maichai

Could u please be more specific, how many Mb is a large size. Most my contacts have a picture and I didn't get any trouble so far.

Thank's in advance, Best regards, Laurent Marchelli

maichai commented 3 years ago

I am sorry, that was monhs ago and I removed a few pictures on which it was choking and since then it works. These were pictures taken in high resolution on the phone. They were several MB, cannot say exactly any more, must have been something in the ballpark of 1-5MB

LaurentMarchelli commented 3 years ago

Hi maichai,

Don't need to be sorry, I should have answered sooner, I deeply apologize to not have to. If it is OK for you, I keep this bug open, however, I'm not sure to have the time to work on it, as I prefer to focus on Baikal's update to fix some CVE.

Best Regard, Laurent Marchelli

maichai commented 3 years ago

Sure, its your time and decision.