LaurentMarchelli / recalbox-rasplex

The repository moved to https://gitlab.com/recalplex/recalplex
GNU General Public License v2.0
11 stars 3 forks source link

Update Rasplex, PlexBlack, Recalbox and noobs #15

Closed eloo closed 7 years ago

eloo commented 7 years ago

Update to latest versions and use noobs lite for faster build.

eloo commented 7 years ago

Hi Laurent, yes I was facing some trouble while merging.. I will recheck the changes in time.

LaurentMarchelli commented 7 years ago

Hi Joseph, Do you need some help to resync ? Regards, Laurent

LaurentMarchelli commented 7 years ago

Hi Joseph,

Your changes have been checked and merged with #18, please resynchronize your fork. Try to avoid working on master branch, as it is your repository default branch, github does not allows the push force. Using pull -r (rebase) on a development branch is always better than merging. Thank for your contribution, noobs lite version save bandwidth.

Best regards, Laurent Marchelli

eloo commented 7 years ago

Hi Laurent,

glad to see you've already adapted my changes. Sorry that i cant fix my PR but I was busy last weeks. Okay yes will try to work on feature branche in future ;) Is there a special reason why you are using noobs lite 2.1 instead of 2.3?

Best regards, Joseph

LaurentMarchelli commented 7 years ago

Hi Joseph,

No problem, when I didn't see any answer I guessed you were busy and as I could handle it ... It's the way a team works, isn't it ? ;-)

I downgraded noobs to version 2.1 because there is a bug since version 2.2, Noobs does not take care of autoboot.txt, so you get the noobs boot menu each time you try to switch, check my commit comment : Noobs_lite version 2_3 does not work with autoboot.txt raspberrypi/noobs#390

In another hand, because I changed the url of the .buildroot submodule, you may have trouble to resync your fork, so let me know if you need any help to resync and clean your master branch.

Best regards, Laurent Marchelli

eloo commented 7 years ago

Okay.. yeah may i will remove my fork and re-fork next time i will contribute.. i guess this is the best solution to work on a clean tree ;)

LaurentMarchelli commented 7 years ago

As u like, :

Best Regards, Laurent Marchelli