LaurentMazare / diffusers-rs

An implementation of the diffusers api in Rust
Apache License 2.0
539 stars 55 forks source link

Implement DPM Solver Multistep Scheduler #22

Closed mspronesti closed 1 year ago

mspronesti commented 1 year ago

Hi, this PR aims at integrating the DPM Solver Multistep Scheduler in this Rust version, as requested in #17 .

A couple of disclaimers:

Cheers :smile: .

mspronesti commented 1 year ago

I just noticed I missed your first question. I "tested" the implementation using the snippet I shared with you in my last PR (changing the scheduler, clearly :)). The codebase should be almost 1:1 with the python version (or, at least, that's what I tried to do).

LaurentMazare commented 1 year ago

Good, could you maybe add a few permalink to the python version in the scheduler code? This is nice for people that would want to see how the code was converted.

mspronesti commented 1 year ago

Sure, is there a specific part you suggest to "annotate" with a permalink ? For instance, here I could replace this comment with a permalink to the python version :) The rest of the code seems (to me) fairly similar to the python implementation, including the comments and the name of the variables.

mspronesti commented 1 year ago

Not sure why one of the checks failed. Seems the classic error one gets when .../cargo/index is corrupted and just needs to be deleted and re-created, or perhaps a network error. Maybe re-running the action solves it ?

LaurentMazare commented 1 year ago

Rerunning fixed indeed this test, I've merged the changes, thanks for the PR!