search

LaurentTreguier / vscode-uncrustify

Code format using uncrustify
66 stars 10 forks source link

Open config file with extension doesn't open graphical editor #37

Open haarse opened 6 years ago

haarse commented 6 years ago

Hi,

The graphical editor is not opened even if I have the setting "uncrustify.graphicalConfig": true, I'm using version 2.13 of the extension and 1.27.2 of Visual Code on Windows10.

Formatting works as expected using Uncrustify.

REgards Håkan

LaurentTreguier commented 6 years ago

I haven't been able to reproduce this, either on Linux or Windows 10. When you say that it doesn't open, do you mean that you're staying on the text editor, or that the graphical editor is completly empty ? This has been a problem before.

I'm going to release a patch just to update dependencies, there are some security issues according to NPM. I don't think this is going to change anything (except if the extension's files are corrupted for some reason), but sometimes problems come from really unexpected places.

haarse commented 6 years ago

Hi Laurent,

I mean that the graphical editor doesn't open at all. I recently changed laptop and the graphical editor worked fine on my previous laptop. I'm not saying that the problem depends on the machine, just that it has been working for me before.

Regards Håkan

LaurentTreguier commented 6 years ago

Is your config file named something other than uncrustify.cfg ? For now, the only possibility I see is a difference in casing between the configured uncrustify.configPath and the actual name of the file. Since Windows' filesystem is case insensitive, uncrustify can probably still pick up the file when formatting, but the file won't be recognized as the correct config file.